From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [RFA] py-inferior.c, check return value of PyList_Append
Date: Wed, 02 Mar 2011 20:27:00 -0000 [thread overview]
Message-ID: <m3r5ap1d63.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4D6E8FFC.2090601@vmware.com> (Michael Snyder's message of "Wed, 02 Mar 2011 10:44:12 -0800")
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> Just making this up as I go, here, need a review.
Michael> 2011-03-02 Michael Snyder <msnyder@vmware.com>
Michael> * py-inferior.c (inferior_to_inferior_object): Check return
Should be build_inferior_list, not inferior_to_inferior_object.
This code is kind of bogus. I agree with your change, but then the
caller needs a change as well. It should do something like:
if (iterate_over_inferiors (...))
{
Py_DECREF (list);
return NULL;
}
Tom
next prev parent reply other threads:[~2011-03-02 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 18:44 Michael Snyder
2011-03-02 20:27 ` Tom Tromey [this message]
2011-03-02 20:40 ` Michael Snyder
2011-03-02 20:56 ` Tom Tromey
2011-03-02 21:21 ` Michael Snyder
-- strict thread matches above, loose matches on Subject: below --
2011-03-02 18:43 Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5ap1d63.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox