From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10765 invoked by alias); 29 Aug 2011 19:46:42 -0000 Received: (qmail 10757 invoked by uid 22791); 29 Aug 2011 19:46:42 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Aug 2011 19:46:24 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7TJkKAD012590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Aug 2011 15:46:20 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7TJkJSP019170; Mon, 29 Aug 2011 15:46:20 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7TJkIHG011417; Mon, 29 Aug 2011 15:46:18 -0400 From: Tom Tromey To: =?utf-8?B?QW5kcsOpIFDDtm5pdHo=?= Cc: gdb-patches@sourceware.org Subject: Re: [RFA] 12843 References: <4E56C5A0.60802@redhat.com> <4E57E9EC.8060706@redhat.com> <201108290920.40589.andre.poenitz@nokia.com> Date: Mon, 29 Aug 2011 19:46:00 -0000 In-Reply-To: <201108290920.40589.andre.poenitz@nokia.com> (=?utf-8?Q?=22An?= =?utf-8?Q?dr=C3=A9_P=C3=B6nitz=22's?= message of "Mon, 29 Aug 2011 09:20:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00578.txt.bz2 Tom> (I'd like -break-insert to avoid linespecs completely, which would be a Tom> big improvement IMO, ... Andr=C3=A9> From an MI client's point of view, passing all location informa= tion as=20 Andr=C3=A9> a single argument is neither wanted nor needed. Yeah. I am not sure why it works this way, as it seems to be against the whole idea of MI. Andr=C3=A9> or even require everything to be quoted as in Andr=C3=A9> 25-break-insert --file "some thing.cpp" --line "794" There's no need; MI already defines an input quoting syntax that is sufficient. Tom> ... but of course we still have to worry about compatibility.) Andr=C3=A9> Just using new flags for the parameters should do the trick in = this case. Andr=C3=A9> In general, in the past, differences between different versions Andr=C3=A9> of gdb have been large enough to require modifications in Andr=C3=A9> consumer code anyway (both to take advantage of new features, a= nd Andr=C3=A9> to handle incompatibilities in input syntax), so requiring 100% Andr=C3=A9> "feature" compatibility _just for the sake of it_ is unlikely to Andr=C3=A9> be helpful. At least I would prefer a syntax with simple, unifo= rm Andr=C3=A9> quoting rules over ad-hoc solutions tied to a specific OS or fi= le Andr=C3=A9> system. For MI, I don't think there is any issue. We can just add options to -break-insert. (I don't know of anybody specifically working on this, but I will at least put it in bugzilla.) My view is that it is best to be compatible with existing "reasonable" practice when possible, where "reasonable" means something akin to "has actually happened". In this case I think we can simplify linespec lexing without unduly breaking things. Tom> I think adopting these rules will make some of my ambiguous linespec Tom> changes simpler.=20 Andr=C3=A9> I wonder whether it would be possible to just leave the current= syntax Andr=C3=A9> unchanged, and introduce a new, better behaved syntax and use s= ome Andr=C3=A9> global setting for toggling between them. So everybody concerne= d about Andr=C3=A9> compatibility would not notice a change, and the others would p= ut=20 Andr=C3=A9> 'set breakpoint syntax 2011' [or whatever] Andr=C3=A9> in their .gdbinit and could use the new way. My first reaction is against this, but I don't have a particularly good explanation for that. I will think about it. Tom