From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93419-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13401 invoked by alias); 1 Aug 2012 23:40:33 -0000
Received: (qmail 13393 invoked by uid 22791); 1 Aug 2012 23:40:32 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Aug 2012 23:40:14 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q71NeBN7031119	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 1 Aug 2012 19:40:11 -0400
Received: from psique (ovpn-113-52.phx2.redhat.com [10.3.113.52])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q71Ne7ae011274;	Wed, 1 Aug 2012 19:40:08 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Pedro Alves <palves@redhat.com>, Tom Tromey <tromey@redhat.com>,        GDB Patches <gdb-patches@sourceware.org>,        Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Adjust `pc-fp.exp' for ppc64/s390x (PR 12659)
In-Reply-To: <m2boiutgm7.fsf@igel.home> (Andreas Schwab's message of "Thu, 02	Aug 2012 00:03:12 +0200")
References: <m3mx2fmxmb.fsf@redhat.com> <5018ECBE.4020007@redhat.com>	<87vch2s83x.fsf@fleche.redhat.com> <50199028.6060208@redhat.com>	<m34noml4mg.fsf@redhat.com> <m2boiutgm7.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
X-URL: http://www.redhat.com
Date: Wed, 01 Aug 2012 23:40:00 -0000
Message-ID: <m3r4rqji5l.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00048.txt.bz2

On Wednesday, August 01 2012, Andreas Schwab wrote:

> Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
>> Index: src/gdb/testsuite/gdb.base/pc-fp.exp
>>
>> ===================================================================
>> --- src.orig/gdb/testsuite/gdb.base/pc-fp.exp
>> +++ src/gdb/testsuite/gdb.base/pc-fp.exp
>> @@ -66,4 +66,4 @@ gdb_test "info register \$fp" "${valueof
>>  # Regression test for
>>  # http://sourceware.org/bugzilla/show_bug.cgi?id=12659>  gdb_test "info register pc fp" \
>> -    "pc: ${valueof_pc}\[\r\n\]+fp: ${valueof_fp}\[\r\n\]+"
>> +    "pc.*\[\r\n\]+fp.*\[\r\n\]+"
>
> That will of course match the erroneous output.

Ok, sorry.

Pedro, the patch below is the second version I sent, to handle Andreas'
observations on m68k-linux.  It is more specialized than the previous
patch.  Is it still OK to apply?

Thanks,

-- 
Sergio

Index: src/gdb/testsuite/gdb.base/pc-fp.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.base/pc-fp.exp
+++ src/gdb/testsuite/gdb.base/pc-fp.exp
@@ -66,4 +66,4 @@ gdb_test "info register \$fp" "${valueof
 # Regression test for
 # http://sourceware.org/bugzilla/show_bug.cgi?id=12659
 gdb_test "info register pc fp" \
-    "pc: ${valueof_pc}\[\r\n\]+fp: ${valueof_fp}\[\r\n\]+"
+    "pc(:)?( |\t)+${valueof_pc}(( |\t)+${valueof_pc} <.*>)?\[\r\n\]+fp(:)?( |\t)+${valueof_fp}(( |\t)+${valueof_fp})?\[\r\n\]+"