From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101555-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27034 invoked by alias); 15 May 2013 22:33:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27023 invoked by uid 89); 15 May 2013 22:33:47 -0000
X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 22:33:47 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FMXk7v004541	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 15 May 2013 18:33:46 -0400
Received: from psique (ovpn-113-83.phx2.redhat.com [10.3.113.83])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4FMXhcv007930	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 15 May 2013 18:33:45 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
References: <51895A2F.8000504@redhat.com>	<CADPb22Sj_5Bp+FhoQYk_9vR5c1D3fXsw4gLFu7v+jmDNSaOPFg@mail.gmail.com>	<5191340B.60100@redhat.com> <519156F5.5090000@redhat.com>	<5193C786.4000207@redhat.com> <5193E2DC.5000200@redhat.com>
X-URL: http://www.redhat.com
Date: Wed, 15 May 2013 22:33:00 -0000
In-Reply-To: <5193E2DC.5000200@redhat.com> (Keith Seitz's message of "Wed, 15	May 2013 12:32:44 -0700")
Message-ID: <m3r4h7kh4p.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00561.txt.bz2

Hi Keith,

I know you have already committed the patch, but I just would like to
ask a few things.

On Wednesday, May 15 2013, Keith Seitz wrote:

> diff --git a/gdb/testsuite/gdb.base/filesym.exp b/gdb/testsuite/gdb.base/filesym.exp
> new file mode 100644
> index 0000000..c9e9c20
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/filesym.exp

> +# Test completion list for "filesy".  We expect the immediate result to
> +# complete to "filesym"; completing again, we expect the symbol name and the
> +# filename (in that order).
> +
> +send_gdb "break filesy\t"
> +gdb_expect {
> +     -re "m\$" {
> +	pass "complete on \"filesy\""
> +
> +	# Now ask for the completion list
> +	send_gdb "\t\t"
> +	gdb_expect {
> +	    -re ".*filesym\[ \t\]+filesym.c.*$gdb_prompt break filesym\$" {
> +		pass "completion list for \"filesym\""
> +	    }
> +
> +	    default {
> +		fail "completion list for \"filesym\""
> +	    }
> +	}
> +    }
> +
> +    default {
> +	fail "complete on \"filesy\""
> +    }
> +}

Wouldn't it be better to use the "complete" command?  Here is what I see
when I use it:

    (gdb) complete break filesy
    break filesym
    break filesym.c

Also, ISTR "send_gdb" is deprecated, and one should use
"gdb_test_multiple" instead.  WDYT?

Thanks,

-- 
Sergio