From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125521 invoked by alias); 12 Jun 2017 11:38:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125512 invoked by uid 89); 12 Jun 2017 11:38:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=waited, himself, monster, scary X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 11:38:39 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5CBYDx4102911 for ; Mon, 12 Jun 2017 07:38:42 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2b1s0g34kr-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 12 Jun 2017 07:38:41 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Jun 2017 12:38:39 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 12 Jun 2017 12:38:38 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5CBcbiE35979418; Mon, 12 Jun 2017 11:38:37 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 36EB5AE056; Mon, 12 Jun 2017 12:36:00 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 119E2AE055; Mon, 12 Jun 2017 12:36:00 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.151]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 12 Jun 2017 12:36:00 +0100 (BST) From: Andreas Arnez To: Simon Marchi Cc: gdb-patches@sourceware.org, qiyaoltc@gmail.com Subject: Re: [PATCH v2 00/19] Various DWARF piece fixes References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <8694ad33433a8f7018b98e8d9eb8e574@polymtl.ca> Date: Mon, 12 Jun 2017 11:38:00 -0000 In-Reply-To: (Andreas Arnez's message of "Wed, 31 May 2017 16:23:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17061211-0008-0000-0000-000004648DDD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061211-0009-0000-0000-00001DED2454 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-12_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706120204 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00305.txt.bz2 On Wed, May 31 2017, Andreas Arnez wrote: > On Tue, May 30 2017, Simon Marchi wrote: > >> I went over the patches that Yao hasn't replied on, namely 13, 14, 16, 17 >> and 19, it all looks good to me (note the little comment on #17). Since >> it's some tricky code, I wasn't always able to convince myself of the >> correctness by just looking at it. But I went through the test cases by >> hand, when applicable, and it gives me enough confidence that the code is >> correct (or at least more correct than the current code :)). > > Thanks a lot for looking at this! > >> I'm not sure I like the merge of the two functions, already scary by >> themselves, in one scarier monster, but I understand the downsides of >> having two separate functions, so I'm ok to go with it. > > Yeah, it's a trade-off. > >> I'll let Yao decide if he wants to go himself through the remaining >> patches. > > OK, I guess I'll wait a few more days for further feedback from Yao (or > others). OK, I've waited a few days by now... Is this ready to push? https://sourceware.org/ml/gdb-patches/2017-05/msg00215.html -- Andreas