From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41403 invoked by alias); 3 Aug 2017 11:13:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41381 invoked by uid 89); 3 Aug 2017 11:13:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=eMail, e-Mail X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Aug 2017 11:13:51 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v73BDlwL119600 for ; Thu, 3 Aug 2017 07:13:50 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2c41ntb4w5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 03 Aug 2017 07:13:49 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Aug 2017 12:13:39 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 3 Aug 2017 12:13:37 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v73BDbmK36896936; Thu, 3 Aug 2017 11:13:37 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F9E5AE053; Thu, 3 Aug 2017 12:09:47 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 40245AE051; Thu, 3 Aug 2017 12:09:47 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.202]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 3 Aug 2017 12:09:47 +0100 (BST) From: Andreas Arnez To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] GDB testsuite: Suppress GCC's colored output References: <7b9c299818a8b32b0198e5d016d47abd@polymtl.ca> Date: Thu, 03 Aug 2017 11:13:00 -0000 In-Reply-To: <7b9c299818a8b32b0198e5d016d47abd@polymtl.ca> (Simon Marchi's message of "Wed, 02 Aug 2017 22:21:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17080311-0040-0000-0000-000003CBB96B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17080311-0041-0000-0000-000025C9CD43 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-03_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708030171 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00056.txt.bz2 On Wed, Aug 02 2017, Simon Marchi wrote: > On 2017-08-02 19:35, Andreas Arnez wrote: >> Newer GCC versions yield colored diagnostic messages by default, which >> may >> be useful when executing GDB interactively from a terminal. But when >> run >> from a GDB test case, the compiler output is written into gdb.log, where >> such escape sequences are usually more inhibiting than helpful to the >> evaluation of test results. So this patch suppresses that. > > That's because you are not using the right viewer :). Try "less -R > gdb.log", you should see the rainbow. Right... That's why I wrote "usually". Such as when using "grep", loading the file into an editor, pasting the error message into an e-Mail, etc. > >> >> gdb/testsuite/ChangeLog: >> >> * lib/gdb.exp (gdb_compile): Suppress GCC's coloring of messages. >> --- >> gdb/testsuite/lib/gdb.exp | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 3d3eaab..9a5c27f 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -3552,6 +3552,9 @@ proc gdb_compile {source dest type options} { >> } >> } >> >> + # Stop the compiler from producing colored output. >> + setenv GCC_COLORS "" >> + >> set result [target_compile $source $dest $type $options] >> >> # Prune uninteresting compiler (and linker) output. > > I was wondering why GCC showed colors even though it's not invoked > "interactively". Dejagnu uses expect's spawn to spawn processes, > including the compiler. spawn allocates a tty for the subprocess, which > is what GCC checks to determine whether or not to enable colors. Right. If spawn used a pipe instead of a pseudo-tty, then GCC wouldn't show colors. > You patch LGTM, but please leave the patch for review for a few days, then > push it if nobody says anything. OK. -- Andreas