From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66728 invoked by alias); 12 Oct 2017 17:00:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63984 invoked by uid 89); 12 Oct 2017 17:00:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Oct 2017 17:00:23 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9CGxBeA030197 for ; Thu, 12 Oct 2017 13:00:20 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2dj94fa7ap-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 12 Oct 2017 13:00:20 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Oct 2017 18:00:18 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 12 Oct 2017 18:00:16 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v9CH0Gi825362548; Thu, 12 Oct 2017 17:00:16 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8AEA42047; Thu, 12 Oct 2017 17:55:56 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 833C542041; Thu, 12 Oct 2017 17:55:56 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.164]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 12 Oct 2017 17:55:56 +0100 (BST) From: Andreas Arnez To: Pedro Alves Cc: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> Date: Thu, 12 Oct 2017 17:00:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 12 Oct 2017 14:47:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17101217-0008-0000-0000-0000049F3AE8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101217-0009-0000-0000-00001E315125 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-12_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710120244 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00315.txt.bz2 On Thu, Oct 12 2017, Pedro Alves wrote: > On 10/09/2017 07:46 PM, Andreas Arnez wrote: > >> @@ -5883,7 +5883,7 @@ proc run_and_get_core {binfile {arg ""}} { >> # specified. Return that path name, or "" if no core file was found. >> >> proc find_core {binfile coredir {destcore ""}} { >> - if {[is_remote target]} { >> + if {![isnative]} { >> warning "Can not access remote core file." >> return "" >> } > > This seems incorrect to me. "isnative" only checks > if the build and target _triplets_ are the same. So > foo-linux-gnu gdb x foo-linux-gnu gdbserver on separate > machine still returns isnative==true. Exactly, that's why I originally wrote is_remote instead. And I also wondered why the core dump tests check isnative. Does anyone run the testsuite on a native remote setup? > I think the real problem is that the native-gdbserver board > returns true to is_remote, when I think it shouldn't. > > Doing that alone results in fallout in the testsuite, of > course. I'm seeing if fixing it is doable. Right, this seems all a bit mixed up to me, similar to the confusing remote_file and remote_exec operations in core_find. -- Andreas