Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sources.redhat.com
Subject: ppc_linux_init_extra_frame_info
Date: Fri, 21 Feb 2003 00:14:00 -0000	[thread overview]
Message-ID: <m3ptpm1odr.fsf@whitebox.local> (raw)

ppc_linux_init_extra_frame_info is clobbering the frame type which
causes dummy_frame_pop to bail out.  The frame type is now set before
INIT_FRAME_INFO is called.

Andreas.

2003-02-21  Andreas Schwab  <schwab@suse.de>

	* ppc-linux-tdep.c (ppc_linux_init_extra_frame_info): Don't set
	frame type to NORMAL_FRAME now that get_prev_frame sets frame
	type before calling INIT_FRAME_INFO.

--- gdb/ppc-linux-tdep.c.~1.23.~	2003-02-04 23:12:42.000000000 +0100
+++ gdb/ppc-linux-tdep.c	2003-02-21 00:29:39.000000000 +0100
@@ -146,18 +146,7 @@ static int ppc_linux_at_sigtramp_return_
    the first instruction of the handler is stepped over instead.  That
    puts us on the second instruction.  (I added the test for the
    first instruction long after the fact, just in case the observed
-   behavior is ever fixed.)
-
-   PC_IN_SIGTRAMP is called from blockframe.c as well in order to set
-   the frame's type (if a SIGTRAMP_FRAME).  Because of our strange
-   definition of in_sigtramp below, we can't rely on the frame's type
-   getting set correctly from within blockframe.c.  This is why we
-   take pains to set it in init_extra_frame_info().
-
-   NOTE: cagney/2002-11-10: I suspect the real problem here is that
-   the get_prev_frame() only initializes the frame's type after the
-   call to INIT_FRAME_INFO.  get_prev_frame() should be fixed, this
-   code shouldn't be working its way around a bug :-(.  */
+   behavior is ever fixed.)  */
 
 int
 ppc_linux_in_sigtramp (CORE_ADDR pc, char *func_name)
@@ -374,10 +363,6 @@ ppc_linux_init_extra_frame_info (int fro
          at trampoline code */
       if (ppc_linux_at_sigtramp_return_path (fi->pc))
 	deprecated_set_frame_type (fi, SIGTRAMP_FRAME);
-      else
-	/* FIXME: cagney/2002-11-10: Is this double bogus?  What
-           happens if the frame has previously been marked as a dummy?  */
-	deprecated_set_frame_type (fi, NORMAL_FRAME);
     }
 }
 


             reply	other threads:[~2003-02-21  0:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-21  0:14 Andreas Schwab [this message]
2003-02-21  1:48 ` ppc_linux_init_extra_frame_info Andrew Cagney
2003-02-21  4:53 ` ppc_linux_init_extra_frame_info Kevin Buettner
2003-02-21 16:55   ` ppc_linux_init_extra_frame_info Andrew Cagney
2003-02-21 17:29     ` ppc_linux_init_extra_frame_info Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ptpm1odr.fsf@whitebox.local \
    --to=schwab@suse.de \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox