From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16707 invoked by alias); 30 Aug 2005 21:44:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16694 invoked by uid 22791); 30 Aug 2005 21:43:59 -0000 Received: from nat-pool-rdu.redhat.com (HELO devserv.devel.redhat.com) (66.187.233.202) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 30 Aug 2005 21:43:59 +0000 Received: from alligator.red-bean.com.redhat.com (vpn26-14.sfbay.redhat.com [172.16.26.14]) by devserv.devel.redhat.com (8.12.11/8.12.11) with ESMTP id j7ULhdHS017157; Tue, 30 Aug 2005 17:43:40 -0400 To: pgilliam@us.ibm.com Cc: gdb-patches@sources.redhat.com Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC References: <200508301459.57189.pgilliam@us.ibm.com> From: Jim Blandy Date: Tue, 30 Aug 2005 21:46:00 -0000 In-Reply-To: <200508301459.57189.pgilliam@us.ibm.com> (Paul Gilliam's message of "Tue, 30 Aug 2005 14:59:57 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-08/txt/msg00255.txt.bz2 Paul Gilliam writes: > I was temped to commit this is obvious, but wanted the warm fuzzy of > peer review. Well, you can have the cold slimy of a review from me. :) Yes, that looks right. Comments: - Could you also add comments above the definitions of tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum in ppc-tdep.h? Perhaps such comments could have prevented the bugs's appearance in the first place. - I'm not sure why the indentation in your patch is weird, but in any case, there seems to be a preference for using spaces in new code, not tabs. Thanks!