From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3532 invoked by alias); 13 Aug 2007 19:41:13 -0000 Received: (qmail 3447 invoked by uid 22791); 13 Aug 2007 19:41:12 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 19:41:08 +0000 Received: (qmail 8223 invoked from network); 13 Aug 2007 19:41:06 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Aug 2007 19:41:06 -0000 To: msnyder@sonic.net Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] stack.c, memory leak (no-effect code?) References: <5638.12.7.175.2.1186784359.squirrel@webmail.sonic.net> From: Jim Blandy Date: Mon, 13 Aug 2007 19:41:00 -0000 In-Reply-To: <5638.12.7.175.2.1186784359.squirrel@webmail.sonic.net> (msnyder@sonic.net's message of "Fri, 10 Aug 2007 15:19:19 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00256.txt.bz2 msnyder@sonic.net writes: > This patch is to fix a memory leak, but while you're looking at it... > does it seem to you that these two blocks have any effect? > > [Sorry if I posted this before, I've been searching for it...] You did post something very much like this, but I recall that the blocks in question in the older post really didn't have any effect. These at least set funname. I'm kind of surprised that they don't set funname to demangled when it's non-NULL.