Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] describe some frame unwinder functions
Date: Mon, 24 Sep 2007 19:12:00 -0000	[thread overview]
Message-ID: <m3ps077u9f.fsf@codesourcery.com> (raw)
In-Reply-To: <1190584664.8479.2.camel@localhost.localdomain> (Thiago Jung Bauermann's message of "Sun, 23 Sep 2007 18:57:44 -0300")


Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
> This patch adds explanations to some functions in the frame unwinder. I
> think they're very helpful (albeit somewhat concise), assuming I got
> them right. :-)

These functions all have comments where they're declared in frame.h.
I think it would be best to fix those if they're not clear; I don't
think we should repeat function head comments in both places.

There seem to be two schools regarding comments.  One says to put them
in header files, becase a module's .h file is its interface, and
that's where people should go to see how to use it.  The other says to
put them directly above the functions, because that's where the actual
code is.

GDB sort of does both, or neither, depending on the age and original
author of the code.

The Subversion project's coding standard followed the header file
approach, with the requirement that the comments had to be good enough
to use the functions without reading their code, in most cases.  Where
that standard is in force, I think header files are the right place.
For example, prologue-value.h, macrotab.h, and macroexp.h all work
fine this way.

For some parts of GDB, the real-life behaviors of the functions
themselves are hairy enough that it may be unrealistic to ever expect
anyone to use them without reading their code.


      reply	other threads:[~2007-09-24 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 21:57 Thiago Jung Bauermann
2007-09-24 19:12 ` Jim Blandy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ps077u9f.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox