Re: small test suite cleanup

Tom Tromey
2009-02-13T18:00:26Z

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre> This only accepts digits, but
Pierre> if you use "/x" for the format,
Pierre> you would get an hexadecimal printout,
Pierre> shouldn't that be also accepted?

Sure. BTW, get_valueofx is another copy of it that is specific to the
/x format.

I did not try to fix bugs in this proc, I just consolidated the
various instances of it.

Pierre> But I don't like the idea of having a
Pierre> procedure that would issue FAIL
Pierre> if used for instance as
Pierre> [get_valueof "/s" "*args.argv" "0"]
Pierre> in gdb main function.

Are you saying you object to this patch?
If so, let me know, and I will revert it.

I'm not planning to fix any of the problems with the current
get_valueof. My view is that this patch is an improvement simply
because it removes code duplication; whatever latent problems there
are were already there. But, feel free to send a patch to fix any or
all of the problems you identified :-)

Tom