From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2952 invoked by alias); 13 Feb 2009 18:00:26 -0000 Received: (qmail 2933 invoked by uid 22791); 13 Feb 2009 18:00:25 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Feb 2009 18:00:17 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1DI0Evh029628; Fri, 13 Feb 2009 13:00:14 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1DI0Du8009256; Fri, 13 Feb 2009 13:00:13 -0500 Received: from opsy.redhat.com (vpn-13-250.rdu.redhat.com [10.11.13.250]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1DI09cn002214; Fri, 13 Feb 2009 13:00:12 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9896B8880F4; Fri, 13 Feb 2009 11:00:06 -0700 (MST) To: "Pierre Muller" Cc: Subject: Re: small test suite cleanup References: <005701c98df9$25262600$6f727200$@u-strasbg.fr> From: Tom Tromey Reply-To: tromey@redhat.com Date: Fri, 13 Feb 2009 18:42:00 -0000 In-Reply-To: <005701c98df9$25262600$6f727200$@u-strasbg.fr> (Pierre Muller's message of "Fri\, 13 Feb 2009 17\:35\:56 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00308.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> This only accepts digits, but Pierre> if you use "/x" for the format, Pierre> you would get an hexadecimal printout, Pierre> shouldn't that be also accepted? Sure. BTW, get_valueofx is another copy of it that is specific to the /x format. I did not try to fix bugs in this proc, I just consolidated the various instances of it. Pierre> But I don't like the idea of having a Pierre> procedure that would issue FAIL Pierre> if used for instance as Pierre> [get_valueof "/s" "*args.argv" "0"] Pierre> in gdb main function. Are you saying you object to this patch? If so, let me know, and I will revert it. I'm not planning to fix any of the problems with the current get_valueof. My view is that this patch is an improvement simply because it removes code duplication; whatever latent problems there are were already there. But, feel free to send a patch to fix any or all of the problems you identified :-) Tom