From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19410 invoked by alias); 15 Jan 2010 21:02:10 -0000 Received: (qmail 19320 invoked by uid 22791); 15 Jan 2010 21:02:09 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jan 2010 21:02:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0FL1CWZ024617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Jan 2010 16:01:13 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0FL1Bew012755; Fri, 15 Jan 2010 16:01:12 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0FL1ADL018076; Fri, 15 Jan 2010 16:01:11 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 1986637819A; Fri, 15 Jan 2010 14:01:10 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: Mihail Zenkov , gdb-patches@sourceware.org Subject: Re: D language support References: <20091224015617.7092112b.mihai.zenkov@gmail.com> <20091230125539.GF2788@adacore.com> <20100109082524.263bcb17.mihai.zenkov@gmail.com> <20100109082830.dd984de8.mihai.zenkov@gmail.com> <20100109142327.GC2007@adacore.com> <20100113064026.14f75ff2.mihai.zenkov@gmail.com> <20100115051024.GA2786@adacore.com> Reply-To: tromey@redhat.com Date: Fri, 15 Jan 2010 21:02:00 -0000 In-Reply-To: <20100115051024.GA2786@adacore.com> (Joel Brobecker's message of "Fri, 15 Jan 2010 09:10:24 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00418.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> +static char* out_str; >> +static char* out_pos; >> +static char* mangled_str; Joel> I prefered it when you had a type, encapsulating the whole bounded Joel> string concept. You can always make it static if you think it helps. Just use an obstack. We already have plenty of expanding data types -- VEC, obstack, dyn_string from libiberty. Unless there is strong proof for a need, don't introduce a new one or a hand-written one. >> + mangled_str = (char *) symbol; Joel> Outch! You are bypassing the "const", preventing potentially useful Joel> compiler warnings. Isn't there a way to avoid this? I looked at this and I don't think there's any need for it. Tom