From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9025 invoked by alias); 30 Aug 2011 17:41:33 -0000 Received: (qmail 9011 invoked by uid 22791); 30 Aug 2011 17:41:32 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 17:41:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UHfBY6030371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 13:41:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7UHfARZ030015; Tue, 30 Aug 2011 13:41:10 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7UHf9q1021617; Tue, 30 Aug 2011 13:41:09 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: matt rice , gdb-patches@sourceware.org Subject: Re: [PATCH 4/7] [python] API for macros: Add methods to get a gdb.Macro. References: <1314198654-9008-1-git-send-email-ratmice@gmail.com> <1314198654-9008-5-git-send-email-ratmice@gmail.com> Date: Tue, 30 Aug 2011 17:41:00 -0000 In-Reply-To: (Phil Muldoon's message of "Tue, 30 Aug 2011 14:03:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00619.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> I think this should return a Tuple. Tuples are immutable, and unless Phil> you for see a use for the user to manipulate the List, we should guard Phil> against it. If you agree, please alter stpy_macros too. Using a tuple means you have to iterate twice -- once to count the objects and once to make the tuple. Since we make a new object every time this method is called, returning a list doesn't seem any worse than a tuple. Tom