From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84907-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21040 invoked by alias); 3 Nov 2011 17:10:27 -0000
Received: (qmail 21030 invoked by uid 22791); 3 Nov 2011 17:10:26 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 17:10:06 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA3HA3RS003989	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 3 Nov 2011 13:10:03 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA3HA2PF021781;	Thu, 3 Nov 2011 13:10:03 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA3HA1RM020952;	Thu, 3 Nov 2011 13:10:01 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] arm reversible : <phase_2_complete>
References: <998639.46560.qm@web112516.mail.gq1.yahoo.com>	<m3fwnusq4e.fsf@fleche.redhat.com>	<321260.58442.qm@web112504.mail.gq1.yahoo.com>	<m3hb6rfc5j.fsf@fleche.redhat.com>	<1316327455.23344.YahooMailNeo@web112509.mail.gq1.yahoo.com>	<1316404058.27177.YahooMailNeo@web112502.mail.gq1.yahoo.com>	<m3pqhzcowx.fsf@fleche.redhat.com>	<1318650316.91503.YahooMailNeo@web112508.mail.gq1.yahoo.com>	<4E9952EA.5040805@codesourcery.com>
Date: Thu, 03 Nov 2011 17:10:00 -0000
In-Reply-To: <4E9952EA.5040805@codesourcery.com> (Yao Qi's message of "Sat, 15	Oct 2011 17:31:22 +0800")
Message-ID: <m3pqh9rv2u.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00084.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> I noticed that test cases in gdb.reverse are *not* enabled in default.

Do you know why that is?  It seems to me that they should be enabled on
platforms where they are known to work.  The current situation means
that any regressions are probably completely missed.

Yao> I am not an expert on record, so I don't have much comment on your code
Yao> logic.  However, some of my cents below.

I think your review was quite helpful.

Tom