From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32478 invoked by alias); 9 Nov 2011 19:06:54 -0000 Received: (qmail 32461 invoked by uid 22791); 9 Nov 2011 19:06:53 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_OC X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 19:06:36 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA9J6EnT001789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Nov 2011 14:06:14 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA9J6D5M011626; Wed, 9 Nov 2011 14:06:14 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA9J6CLJ026652; Wed, 9 Nov 2011 14:06:12 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/procfs] /proc/.../map file descriptor leak References: <1320864439-12456-1-git-send-email-brobecker@adacore.com> Date: Wed, 09 Nov 2011 19:06:00 -0000 In-Reply-To: <1320864439-12456-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Wed, 9 Nov 2011 10:47:19 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00253.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Digging further, I found that we leak the file descriptor created Joel> when opening the procfs map file. we create a cleanup routine to make Joel> sure that the associated file descriptor gets closed, but we never Joel> call the cleanup. This tickled a memory: http://sourceware.org/ml/gdb-patches/2008-10/msg00683.html I didn't touch iterate_over_mappings though, so the old patch is complementary. I think your patch is good. I agree it is cleaner the way you wrote it. Tom