From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] GDB/MI: crash printing "_task" (Ada) argument
Date: Mon, 30 Jan 2012 19:58:00 -0000 [thread overview]
Message-ID: <m3pqe1nev6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1327906636-20099-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 30 Jan 2012 10:57:16 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> if (SYMBOL_IS_ARGUMENT (sym))
Joel> sym2 = lookup_symbol (SYMBOL_NATURAL_NAME (sym),
Joel> block, VAR_DOMAIN,
Joel> (int *) NULL);
FWIW the correct version is in stack.c:iterate_over_block_arg_vars.
It would be nice not to have separate code in MI. I didn't look to see
why it is done this way.
Joel> Tested on x86_64-linux, no regression. I will commit in a few days
Joel> unless there are objections.
I agree it is correct.
Tom
next prev parent reply other threads:[~2012-01-30 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 7:01 Joel Brobecker
2012-01-30 19:58 ` Tom Tromey [this message]
2012-01-30 20:07 ` Tom Tromey
2012-02-03 7:34 ` Joel Brobecker
2012-07-19 7:53 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pqe1nev6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox