From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30261 invoked by alias); 7 Nov 2013 07:10:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30251 invoked by uid 89); 7 Nov 2013 07:10:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from Unknown (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Nov 2013 07:09:33 +0000 Received: by mail-pa0-f44.google.com with SMTP id fb1so185946pad.3 for ; Wed, 06 Nov 2013 23:09:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=fJ4PbMN1s0vXqm+a7pyvjk6qBQhsUztKM0455/AIPJk=; b=QOURjqmwyMIcRSLC58DHwu5mll8ylrTmIBu4aH1U922no0vhebAwuLKNkK9Y6D7mbk B6oQpIFS1EOJGdpr6MIofjrSH35+RbO9VyPOTYUgB/guDxbdt/ZK9hwMLMxXyFhqAENh x7/Xm8rmeCUHOj/eITj4zq9J7brsSjfNdUE3iFuIAKxs1TTAtH7DFFZaMZIQ8z6177+1 cs8idVLOHWTJCBVq10a0NKklYt6uzc5hCexy6wKjteSpWvEgyoB6JNrw5W87MIGwHLiY KX4FxKQPOzi+zxhdO+fDaubfl8zSCTzd0IC8sOEdn7jq3cFJljb/c13k/on6oe1z8yiM aBcw== X-Gm-Message-State: ALoCoQn92E4KMJGTc+Y9ATGQbqYnzbrIfKF2pFZdExCXXMfR+JzZ//1UimUSjKLf3mGZf6Dav8l1 X-Received: by 10.66.142.132 with SMTP id rw4mr8288809pab.6.1383808164014; Wed, 06 Nov 2013 23:09:24 -0800 (PST) Received: from seba.sebabeach.org.sebabeach.org (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id uw6sm2805437pbc.8.2013.11.06.23.09.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2013 23:09:23 -0800 (PST) From: Doug Evans To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c References: <527AB482.80600@earthlink.net> Date: Thu, 07 Nov 2013 07:11:00 -0000 In-Reply-To: <527AB482.80600@earthlink.net> (Stan Shebs's message of "Wed, 06 Nov 2013 13:28:34 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00162.txt.bz2 Stan Shebs writes: > On 11/6/13 9:00 AM, Doug Evans wrote: >> Hi. >> >> There's nothing python-specific about the bulk of this code so I've >> moved it out of py-type.c. >> >> Ok to check in? >> >> 2013-11-06 Doug Evans >> >> * gdbtypes.c: #include bcache.h, dwarf2loc.h. >> (type_equality_entry): Move here from python/py-type.c. >> (type_equality_entry_d): Ditto. >> (compare_maybe_null_strings, check_types_equal): Ditto. >> (check_types_worklist, types_deeply_equal): Ditto. >> * gdbtypes.h (types_deeply_equal): Declare. >> * python/py-type.c: Remove inclusion of bcache.h, dwarf2loc.h. >> (typy_richcompare): Update. >> > > +/* A helper function for tyscm_richcompare that checks two types for > + "deep" equality. Returns non-zero if the types are considered the > + same, zero otherwise. */ > > "tyscm_richcompare"? Should that be typy_... ? Heh. > The comments should be maybe be phrased to emphasize the > quasi-librariness of the code, so that future generations aren't > confused if it seems unused by core GDB (which could happen if python > becomes plugin > instead of subdir, for example). Agreed.