Re: [PATCH v5 5/8] Move linux_find_memory_regions_full & co.

Tom Tromey
2014-05-19T19:19:20Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> this should be just a move with no changes.

Jan> 2014-02-26 Aleksandar Ristovski <aristovski@qnx.com

Jan> Move linux_find_memory_regions_full & co.
Jan> * common/target-utils.c (string.h, gdb_assert.h): Include.
Jan> (read_alloc, read_stralloc): Move definitions from target.c.
Jan> * common/target-utils.h (read_alloc_pread_ftype): New typedef.
Jan> (read_alloc): New declaration.
Jan> (read_stralloc_func_ftype): New typedef.
Jan> (read_stralloc): New declaration.
Jan> * common/linux-maps.c (fcntl.h, unistd.h, target.h, gdb_assert.h)
Jan> (ctype.h, string.h, target-utils.h): Include.
Jan> (read_mapping): Move from linux-tdep.c.
Jan> [GDBSERVER] (linux_find_memory_read_stralloc_1_pread): New function.
Jan> [GDBSERVER] (linux_find_memory_read_stralloc_1): New function.
Jan> (linux_find_memory_read_stralloc): New function.
Jan> (linux_find_memory_regions_full): Move from linux-tdep.c.
Jan> * common/linux-maps.h (read_mapping): New declaration.
Jan> (linux_find_memory_region_ftype): Moved typedef from linux-tdep.c.
Jan> (linux_find_memory_regions_full): New declaration.
Jan> * linux-tdep.c (linux-maps.h): Include.
Jan> (read_mapping): Moved to common/linux-maps.c.
Jan> (linux_find_memory_region_ftype): Moved typedef to common/linux-maps.h.
Jan> (linux_find_memory_regions_full): Moved definition to
Jan> common/linux-maps.c.
Jan> * target.c (target-utils.h): Include.
Jan> (read_alloc_pread_ftype): Moved typedef to common/target-utils.h.
Jan> (read_alloc, read_stralloc): Moved definitions to
Jan> common/target-utils.c.

Ok.

I appreciate how the patch series was constructed to make this patch
obvious. Thanks.

Tom