From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30011 invoked by alias); 5 Jul 2014 12:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29996 invoked by uid 89); 5 Jul 2014 12:14:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 05 Jul 2014 12:14:23 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s65CEJX2007775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 5 Jul 2014 08:14:19 -0400 Received: from psique (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s65CEGRf020187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 5 Jul 2014 08:14:18 -0400 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures. References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> <87zjgobth0.fsf@Argo.krisman.be> X-URL: http://www.redhat.com Date: Sat, 05 Jul 2014 12:14:00 -0000 In-Reply-To: <87zjgobth0.fsf@Argo.krisman.be> (Gabriel Krisman Bertazi's message of "Fri, 04 Jul 2014 20:21:47 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00099.txt.bz2 On Friday, July 04 2014, Gabriel Krisman Bertazi wrote: >> BTW, I recommend that this testcase be simplified. Instead of: > > I applied your suggestions. Below is a new version of the patch that > simplifies the testcase. Thanks! It is missing a (new) ChangeLog entry; other than that, I believe it is fine to be applied. Now it's just a matter of waiting for a maintainer's review/approval :-). > diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp > index 579db03..1ac3623 100644 > --- a/gdb/testsuite/gdb.fortran/array-element.exp > +++ b/gdb/testsuite/gdb.fortran/array-element.exp > @@ -31,18 +31,9 @@ if ![runto sub_] then { > continue > } > > -set bp_location [gdb_get_line_number "continue"] > -gdb_test "break $bp_location" \ > - "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \ > - "breakpoint at continue" > - > -gdb_test "continue" \ > - "Continuing\\..*Breakpoint.*" \ > - "continue to breakpoint" > -gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" > +gdb_breakpoint [gdb_get_line_number "continue"] > +gdb_continue_to_breakpoint "continue" > > -gdb_test "continue" \ > - "Continuing\\..*Breakpoint.*" \ > - "continue to breakpoint once again" > +gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" > gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a" -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/