From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107042 invoked by alias); 16 Mar 2018 19:41:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107026 invoked by uid 89); 16 Mar 2018 19:41:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*o:Research X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Mar 2018 19:41:38 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2GJYstq033505 for ; Fri, 16 Mar 2018 15:41:37 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2grj7xcme3-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Fri, 16 Mar 2018 15:41:36 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Mar 2018 19:41:35 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 16 Mar 2018 19:41:34 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2GJfXAH55509168; Fri, 16 Mar 2018 19:41:33 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 44FACAE058; Fri, 16 Mar 2018 19:31:58 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E6DFAE055; Fri, 16 Mar 2018 19:31:58 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.222]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 16 Mar 2018 19:31:58 +0000 (GMT) From: Andreas Arnez To: Simon Marchi Cc: Subject: Re: [PATCH 1/3] Fix tspeed test case: copy libinproctrace to target References: <1521043903-18837-1-git-send-email-arnez@linux.vnet.ibm.com> <1521043903-18837-2-git-send-email-arnez@linux.vnet.ibm.com> Date: Fri, 16 Mar 2018 19:41:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 15 Mar 2018 17:40:04 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18031619-0040-0000-0000-00000422191E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031619-0041-0000-0000-000026252799 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-16_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803160232 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00325.txt.bz2 On Thu, Mar 15 2018, Simon Marchi wrote: > On 2018-03-14 12:11 PM, Andreas Arnez wrote: >> The tspeed test case does not execute correctly because libinproctrace.so >> is not copied to the target. This is fixed. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.trace/tspeed.exp: Add invocation of gdb_load_shlib to ensure >> that libinproctrace is copied to the target. >> --- >> gdb/testsuite/gdb.trace/tspeed.exp | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp >> index d53608c51b..ecd36d2d9b 100644 >> --- a/gdb/testsuite/gdb.trace/tspeed.exp >> +++ b/gdb/testsuite/gdb.trace/tspeed.exp >> @@ -19,6 +19,7 @@ standard_testfile >> set executable $testfile >> >> set ipalib [get_in_proc_agent] >> +gdb_load_shlib $ipalib >> >> if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ >> executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } { >> > > LGTM. Thanks, pushed. -- Andreas