From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14191 invoked by alias); 5 Jun 2009 18:53:48 -0000 Received: (qmail 14180 invoked by uid 22791); 5 Jun 2009 18:53:48 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 18:53:42 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n55Ipa9F008787; Fri, 5 Jun 2009 14:51:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n55IpYen018901; Fri, 5 Jun 2009 14:51:34 -0400 Received: from opsy.redhat.com (vpn-12-153.rdu.redhat.com [10.11.12.153]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n55IpXP0029636; Fri, 5 Jun 2009 14:51:33 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CC99737861B; Fri, 5 Jun 2009 12:51:32 -0600 (MDT) To: "Pierre Muller" Cc: , "'Thiago Jung Bauermann'" , Subject: Re: TR: ARI warning list change Fri May 29 01:53:26 UTC 2009 References: <000001c9e02a$034bb030$09e31090$@u-strasbg.fr> From: Tom Tromey Reply-To: tromey@redhat.com Date: Fri, 05 Jun 2009 18:53:00 -0000 In-Reply-To: <000001c9e02a$034bb030$09e31090$@u-strasbg.fr> (Pierre Muller's message of "Fri\, 29 May 2009 08\:52\:19 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00111.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> Here is another example of the email that is generated Pierre> by my patch to update-web-ari. Pierre> It seems like you have forgotten a bunch of _() Pierre> macros. Sorry about that. I am going to commit the appended patch to fix the problem. Pierre> A possible improvement would be to send this message directly to Pierre> people that committed a change to the sources that Pierre> generated a new warning. Pierre> Is it possible to extract the commits from the last 24 hours Pierre> to find out to whom this kind of message should be sent? With CVS, it can be done, but very easily. Tom 2009-06-05 Tom Tromey * varobj.c (update_dynamic_varobj_children): Wrap error text in _(). (install_visualizer): Likewise. (varobj_set_visualizer): Likewise. Index: varobj.c =================================================================== RCS file: /cvs/src/src/gdb/varobj.c,v retrieving revision 1.132 diff -u -r1.132 varobj.c --- varobj.c 4 Jun 2009 21:56:22 -0000 1.132 +++ varobj.c 5 Jun 2009 18:49:57 -0000 @@ -850,19 +850,19 @@ if (!children) { gdbpy_print_stack (); - error ("Null value returned for children"); + error (_("Null value returned for children")); } make_cleanup_py_decref (children); if (!PyIter_Check (children)) - error ("Returned value is not iterable"); + error (_("Returned value is not iterable")); iterator = PyObject_GetIter (children); if (!iterator) { gdbpy_print_stack (); - error ("Could not get children iterator"); + error (_("Could not get children iterator")); } make_cleanup_py_decref (iterator); @@ -879,7 +879,7 @@ inner = make_cleanup_py_decref (item); if (!PyArg_ParseTuple (item, "sO", &name, &py_v)) - error ("Invalid item from the child list"); + error (_("Invalid item from the child list")); if (PyObject_TypeCheck (py_v, &value_object_type)) { @@ -1383,7 +1383,7 @@ if (!visualizer && var->children_requested) varobj_list_children (var); #else - error ("Python support required"); + error (_("Python support required")); #endif } @@ -1454,7 +1454,7 @@ if (! pretty_printer) { gdbpy_print_stack (); - error ("Could not evaluate visualizer expression: %s", visualizer); + error (_("Could not evaluate visualizer expression: %s"), visualizer); } if (pretty_printer == Py_None) @@ -1467,7 +1467,7 @@ do_cleanups (back_to); #else - error ("Python support required"); + error (_("Python support required")); #endif }