From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15997 invoked by alias); 30 Jun 2009 19:50:01 -0000 Received: (qmail 15988 invoked by uid 22791); 30 Jun 2009 19:50:00 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_32,J_CHICKENPOX_33,J_CHICKENPOX_34,J_CHICKENPOX_35,J_CHICKENPOX_37,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Jun 2009 19:49:54 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5UJnrYX023875 for ; Tue, 30 Jun 2009 15:49:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5UJnqRZ007634; Tue, 30 Jun 2009 15:49:52 -0400 Received: from opsy.redhat.com (vpn-225-35.phx2.redhat.com [10.3.225.35]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5UJnpgY023108; Tue, 30 Jun 2009 15:49:51 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 5FEFF4852A; Tue, 30 Jun 2009 13:49:50 -0600 (MDT) To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix parallel gdb/ make check//% References: <20090630174650.GB24648@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Tue, 30 Jun 2009 19:50:00 -0000 In-Reply-To: <20090630174650.GB24648@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue\, 30 Jun 2009 19\:46\:50 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00888.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Currently there were: Jan> missing optional @SUBDIRS@: gdb.stabs gdb.gdbtk gdb.hp Jan> missing static: gdb.gdb gdn.modulas gdb.reverse Jan> I may miss the original code goal. I think the existing sub-sub configury stuff is just weird. I am not sure what the point of it is; by default, runtest just runs all the .exp files it finds, and I didn't see anything that would change that. I'd like to nuke all the subdir Makefiles and configure stuff below testsuite. It is a lot of stuff that does very little -- it doesn't even really do the one thing it is intended to do. Jan> -TEST_DIRS = gdb.base1 gdb.base2 $(filter-out gdb.base,$(sort $(notdir $(patsubst %/,%,$(dir $(wildcard $(srcdir)/gdb.*/*.exp)))))) Jan> +TEST_DIRS = gdb.base1 gdb.base2 $(filter-out gdb.base,$(ALL_SUBDIRS)) The original code here tries to mimic what runtest does: run all the .exp files that match the tool name. We're generally passing --directory to runtest in the parallel case, so this finds all the directories holding .exp files. I think the new patch must not be right. What runs gdb.modula2? Or gdb.gdb? AFAICT neither of these ever ends up in ALL_SUBDIRS. I don't really understand what caused the error you saw. The code is intended to make the output directories as it goes (see the .dir dependencies) and all the subdirs should be made and tested before dg-extract-results.sh is invoked. Tom