From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21700 invoked by alias); 11 Sep 2009 22:29:12 -0000 Received: (qmail 21689 invoked by uid 22791); 11 Sep 2009 22:29:11 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 22:29:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BMT6At031022; Fri, 11 Sep 2009 18:29:06 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8BMT5b2021629; Fri, 11 Sep 2009 18:29:05 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n8BMT4Dj004914; Fri, 11 Sep 2009 18:29:04 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B0373378188; Fri, 11 Sep 2009 16:29:03 -0600 (MDT) From: Tom Tromey To: Michael Snyder Cc: "gdb-patches\@sourceware.org" Subject: Re: [RFA] reverse debugging tests References: <4AAAB750.8000209@vmware.com> Reply-To: tromey@redhat.com Date: Fri, 11 Sep 2009 22:29:00 -0000 In-Reply-To: <4AAAB750.8000209@vmware.com> (Michael Snyder's message of "Fri, 11 Sep 2009 13:47:12 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00344.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> Note, I've only done one of the several tests here -- Michael> if this change is approved, I'll change the others the same way. Thanks for doing this. Michael> So I've made two changes: Michael> 1) In place of "if ![target_info exists gdb,can_reverse]" Michael> substitute Michael> +if [istarget "*linux*"] then { Michael> + if { ![istarget "i?86-*linux*"] && ![istarget "amd64-*linux*"] } then { Michael> + # test process record on i?86 and amd64 linux Michael> + return; Michael> + } Michael> +} I assume the old gdb,can_reverse and gdb,use_precord target settings no longer make sense. I would recommend putting each of these snippets into a function in lib/gdb.exp. That way it is simpler to update them in the future. Michael> + gdb_test "record" "" "Turn on process record" Michael> + # FIXME: command ought to acknowledge, so we can test if it Michael> succeeded. This seems like a good idea. Otherwise this looks fine to me. Tom