From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31650 invoked by alias); 23 Jul 2010 22:50:12 -0000 Received: (qmail 31640 invoked by uid 22791); 23 Jul 2010 22:50:12 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Jul 2010 22:50:07 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6NMniwQ024644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Jul 2010 18:49:45 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6NMnioA021571; Fri, 23 Jul 2010 18:49:44 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6NMnhw7009058; Fri, 23 Jul 2010 18:49:43 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 713AA3797F4; Fri, 23 Jul 2010 16:49:43 -0600 (MDT) From: Tom Tromey To: Jerome Guitton Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Nullified garbage-collected global variables References: <1278948088-15391-1-git-send-email-guitton@adacore.com> <20100720154223.GA80443@adacore.com> <20100721133019.GA51363@adacore.com> Date: Fri, 23 Jul 2010 22:50:00 -0000 In-Reply-To: <20100721133019.GA51363@adacore.com> (Jerome Guitton's message of "Wed, 21 Jul 2010 15:30:19 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00377.txt.bz2 >>>>> "Jerome" == Jerome Guitton writes: Jerome> Unless you object, I will commit this new version. Jerome> gdb/ChangeLog: Jerome> * dwarf2read.c (add_partial_symbol): Do not add a global variable if Jerome> its adress is null. Add comment to explain why. Jerome> (new_symbol): Ditto. Looks ok to me. FWIW -- I prefer it if a fix and its corresponding test case are submitted and committed as a unit. I think it is more logical, and also the test case sometimes helps the review of the patch. Tom