Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
	       Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA] Fix setting of VSX registers
Date: Wed, 28 Jul 2010 21:34:00 -0000	[thread overview]
Message-ID: <m3ocdrl2a1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1280165485.2661.85.camel@hactar> (Thiago Jung Bauermann's	message of "Mon, 26 Jul 2010 14:31:25 -0300")

>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Tom> I don't understand why the new gdb_test calls have an empty "message"
Tom> argument.

Thiago> So that they don't increase the test count. They are just sending
Thiago> command to GDB to set the stage for the actual tests, they're of no
Thiago> intrinsic interest to the testcase.

Yeah, that makes sense.  This is a sort of generic problem in dejagnu.

Anyway, I am not sure this approach will work, because gdb_test calls
gdb_test_multiple, which has a different default and which also may call
'fail'.

One approach would be to refactor these procs so that your use can work.
I think this would be nice to have -- I think it would be good to have
fewer boilerplate tests with "synthetic" names, ones that nobody is
interested in.

Another approach would be to just give up and add a new test.  That is
sort of more traditional ;-)

Tom


  parent reply	other threads:[~2010-07-28 21:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21 18:59 Thiago Jung Bauermann
2010-07-22 16:06 ` Tom Tromey
2010-07-26 17:31   ` Thiago Jung Bauermann
2010-07-27 15:20     ` Joel Brobecker
2010-07-27 16:14       ` Thiago Jung Bauermann
2010-07-28 21:34     ` Tom Tromey [this message]
2010-07-28 21:43       ` Joel Brobecker
2010-07-28 21:57         ` Tom Tromey
2010-08-18 21:18   ` Thiago Jung Bauermann
2010-08-19  9:50     ` Joel Brobecker
2010-08-19 17:56       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ocdrl2a1.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=bauerman@br.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox