From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30902 invoked by alias); 31 Aug 2010 16:51:02 -0000 Received: (qmail 30875 invoked by uid 22791); 31 Aug 2010 16:51:01 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 16:50:55 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7VGoaVq029265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Aug 2010 12:50:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7VGfdkp008255; Tue, 31 Aug 2010 12:41:39 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7VGfcYm016740; Tue, 31 Aug 2010 12:41:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 7B3913792BC; Tue, 31 Aug 2010 10:41:37 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: Make function typedef for find memory region References: <20100830085953.GA25961@host1.dyn.jankratochvil.net> <20100830141454.GG2986@adacore.com> <20100830142507.GA1356@host1.dyn.jankratochvil.net> <20100831130152.GB9173@host1.dyn.jankratochvil.net> Date: Tue, 31 Aug 2010 16:51:00 -0000 In-Reply-To: <20100831130152.GB9173@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 31 Aug 2010 15:01:52 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00551.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Tom> One case is the "bcache" case: you have a relatively simple data Tom> structure with a defined public API. In this case, I find it it Tom> convenient to be able to read the header file to see the entire exported Tom> API, without being distracted by the implementation. This case is maybe Tom> not as typical as we might like; many data types in gdb are semi-opaque Tom> at best. Jan> This is definitely a disagreement. Yeah. And of course, I will follow whatever we collectively agree upon. Jan> Such general guide should be in doc/gdbint.texinfo . I would rather get rid of this document, if possible. Having it separate from the source means that modifying it is usually an afterthought. It is better, IMO, to have the comments near the source, because that increases the likelihood that a reviewer will remember to ask for comment updates when a patch changes something. Tom> The second case is implementations of virtual methods. Jan> Implementation should name the field in the interface to be able to jump Jan> there. I like this idea. Tom