From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16499 invoked by alias); 10 Sep 2010 20:15:36 -0000 Received: (qmail 16491 invoked by uid 22791); 10 Sep 2010 20:15:36 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Sep 2010 20:15:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKFSNn025613 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 Sep 2010 16:15:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKFSvW032384; Fri, 10 Sep 2010 16:15:28 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKFRet013020; Fri, 10 Sep 2010 16:15:28 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 7DD363792BD; Fri, 10 Sep 2010 14:15:27 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] PR 11992 "Regression: C++ this scope sometimes does not work" References: <4C8A80A4.9060707@redhat.com> Date: Fri, 10 Sep 2010 20:39:00 -0000 In-Reply-To: <4C8A80A4.9060707@redhat.com> (sami wagiaalla's message of "Fri, 10 Sep 2010 15:01:56 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00233.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> This is a fix and a test case for the above mentioned bug. Sami> The patch was regression testing on F13 on x8664 with gcc 4.4.4. Thanks. Sami> +# test that koening lookup does not effect Sami> +# member variable lookup s/effect/affect/ Also, comments should start with an upper case letter and end with a period. This is ok with that change. Tom