From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78423-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3084 invoked by alias); 18 Feb 2011 18:44:02 -0000
Received: (qmail 3076 invoked by uid 22791); 18 Feb 2011 18:44:01 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 18:43:57 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1IIhnLG015995	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 18 Feb 2011 13:43:49 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1IIhnpG024340;	Fri, 18 Feb 2011 13:43:49 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1IIhmGQ002510;	Fri, 18 Feb 2011 13:43:48 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id DEF84378509; Fri, 18 Feb 2011 11:43:47 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver
References: <4D30E23F.3080103@codesourcery.com>	<m31v4blatz.fsf@fleche.redhat.com> <4D34C9DE.3040603@codesourcery.com>	<m3mxmyi6i3.fsf@fleche.redhat.com> <4D375F44.70504@codesourcery.com>
Date: Fri, 18 Feb 2011 18:49:00 -0000
In-Reply-To: <4D375F44.70504@codesourcery.com> (Yao Qi's message of "Wed, 19	Jan 2011 15:01:40 -0700")
Message-ID: <m3oc69xjx8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00490.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> +$(LIBCOMMON): $(LIBCOMMON_DIR)/Makefile
Yao> +	@$(MAKE) $(FLAGS_TO_PASS) DO=all --directory=common

--directory is a GNU make feature.
By the current rules that makes it not ok.

I think it would be a good idea to require GNU make, but I think that is
something that needs general agreement.

Tom