From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25229 invoked by alias); 28 Feb 2011 15:42:52 -0000 Received: (qmail 25220 invoked by uid 22791); 28 Feb 2011 15:42:51 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Feb 2011 15:42:39 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1SFgQei028766 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Feb 2011 10:42:26 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1SFgPlA019906; Mon, 28 Feb 2011 10:42:25 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1SFgPDW030806; Mon, 28 Feb 2011 10:42:25 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id C317F3784EE; Mon, 28 Feb 2011 08:42:24 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: Michael Snyder , "gdb-patches\@sourceware.org" Subject: Re: [RFC] Compile GDB with -Wshadow? References: <4D698B92.3070309@vmware.com> <4D698C33.9040101@vmware.com> <20110228045225.GC30306@adacore.com> <20110228045735.GD30306@adacore.com> Date: Mon, 28 Feb 2011 15:48:00 -0000 In-Reply-To: <20110228045735.GD30306@adacore.com> (Joel Brobecker's message of "Mon, 28 Feb 2011 08:57:35 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00902.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> I wish the compiler would warn us about things like this... The patch >> looks correct to me, but I will let Ken and Ulrich take a look. Perhaps >> they'll be able to suggest a more specific name than `length2' ;-). Joel> Howzabout we add -Wshadow to the list of warning compiler switches Joel> for GCC? Something like this (untested for now, just to give an idea Joel> for this discussion)... -Wshadow also warns about a local variable whose name clashes with a function. I find this to be a bit unfriendly. I wish GCC had a variant of -Wshadow where clashes with functions were only reported if the shadowing variable had pointer-to-function type. That said, I don't really mind if we have to change some local variable names around to satisfy various platforms. It is just a lot of work. Tom