From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22249 invoked by alias); 19 Apr 2011 12:52:51 -0000 Received: (qmail 22240 invoked by uid 22791); 19 Apr 2011 12:52:50 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 12:52:37 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3JCqbDs022321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Apr 2011 08:52:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3JCqa0U031512; Tue, 19 Apr 2011 08:52:36 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3JCqZo1020253; Tue, 19 Apr 2011 08:52:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id AF17C37930B; Tue, 19 Apr 2011 06:52:35 -0600 (MDT) From: Tom Tromey To: Marek Polacek Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649) References: <4DAC6924.2000100@redhat.com> <4DAD333D.6010103@redhat.com> Date: Tue, 19 Apr 2011 12:52:00 -0000 In-Reply-To: <4DAD333D.6010103@redhat.com> (Marek Polacek's message of "Tue, 19 Apr 2011 09:01:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00313.txt.bz2 >>>>> "Marek" == Marek Polacek writes: Tom> I think this should not be needed. Marek> It is needed. Not that I'd see WHY it is so. But this is what I Marek> get without those "\\": Marek> FAIL: gdb.base/setshow.exp: set radix 11 Maybe gdb.log says something, or maybe running with --verbose would help. Also, looking at the code, it seems to me that the section that sets the prompt to "(FooBarBaz) " should also set and restore gdb_prompt. That is because gdb_test_multiple references this. What do you think? Tom