From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10321 invoked by alias); 9 May 2011 15:06:50 -0000 Received: (qmail 10295 invoked by uid 22791); 9 May 2011 15:06:47 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 May 2011 15:06:26 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p49F6I0T026811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 9 May 2011 11:06:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p49F6H84013808; Mon, 9 May 2011 11:06:18 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p49F6H7g012677; Mon, 9 May 2011 11:06:17 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BA9AA378498; Mon, 9 May 2011 09:06:16 -0600 (MDT) From: Tom Tromey To: Yao Qi Cc: "Joseph S. Myers" , gdb-patches@sourceware.org Subject: Re: [patch, testsuite] Tests to _Complex type References: <4DC401D0.1050500@codesourcery.com> <4DC75036.4040806@codesourcery.com> Date: Mon, 09 May 2011 15:06:00 -0000 In-Reply-To: <4DC75036.4040806@codesourcery.com> (Yao Qi's message of "Mon, 09 May 2011 10:23:50 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00220.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Shall we propagate _Complex related tests to each *.exp file, such as Yao> funcargs.exp/callfuncs.exp/varargs.exp/struct.arg? or keep all _Complex Yao> tests in a single exp file complex.exp? I prefer the former one, but I Yao> am afraid this will break some platforms which don't support _Complex. Yao> Thoughts? As long as the change is done cleanly, and there is some mechanism for avoiding the troublesome code on platforms not supporting _Complex (and in particular making the rest of the tests in these files continue to execute on such a platform), then it doesn't matter to me where the tests end up. Tom