Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@redhat.com>
To: Vikash Jain <vikashjin@gmail.com>
Cc: gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: GDB: error detected on stdin
Date: Tue, 24 May 2011 14:32:00 -0000	[thread overview]
Message-ID: <m3oc2sw4oh.fsf@redhat.com> (raw)
In-Reply-To: <BANLkTi=dK2wZ8nN86QvWpePEk0DEgLQ2jA@mail.gmail.com> (Vikash	Jain's message of "Tue, 24 May 2011 18:56:48 +0530")

Vikash Jain <vikashjin@gmail.com> writes:

> I'm trying to pipe commands to gdb but I get the following messages.
> Will it cause any problems? How do i resolve the same?

2011-05-24  Andreas Schwab  <schwab@redhat.com>

	* event-loop.c (handle_file_event): Don't handle POLLHUP as error.

--- event-loop.c.~1.49.~	2011-03-22 11:59:52.000000000 +0100
+++ event-loop.c	2011-05-24 16:27:28.614311098 +0200
@@ -759,7 +759,6 @@ handle_file_event (event_data data)
   int mask;
 #ifdef HAVE_POLL
   int error_mask;
-  int error_mask_returned;
 #endif
   int event_file_desc = data.integer;
 
@@ -783,22 +782,19 @@ handle_file_event (event_data data)
 	  if (use_poll)
 	    {
 #ifdef HAVE_POLL
+	      /* POLLHUP means EOF, but can be combined with POLLIN to
+		 signal more data to read.  */
 	      error_mask = POLLHUP | POLLERR | POLLNVAL;
-	      mask = (file_ptr->ready_mask & file_ptr->mask) |
-		(file_ptr->ready_mask & error_mask);
-	      error_mask_returned = mask & error_mask;
+	      mask = file_ptr->ready_mask & (file_ptr->mask | error_mask);
 
-	      if (error_mask_returned != 0)
+	      if ((mask & (POLLERR | POLLNVAL)) != 0)
 		{
 		  /* Work in progress.  We may need to tell somebody
 		     what kind of error we had.  */
-		  if (error_mask_returned & POLLHUP)
-		    printf_unfiltered (_("Hangup detected on fd %d\n"),
-				       file_ptr->fd);
-		  if (error_mask_returned & POLLERR)
+		  if (mask & POLLERR)
 		    printf_unfiltered (_("Error detected on fd %d\n"),
 				       file_ptr->fd);
-		  if (error_mask_returned & POLLNVAL)
+		  if (mask & POLLNVAL)
 		    printf_unfiltered (_("Invalid or non-`poll'able fd %d\n"),
 				       file_ptr->fd);
 		  file_ptr->error = 1;

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."


       reply	other threads:[~2011-05-24 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BANLkTi=dK2wZ8nN86QvWpePEk0DEgLQ2jA@mail.gmail.com>
2011-05-24 14:32 ` Andreas Schwab [this message]
2011-05-24 19:14   ` Tom Tromey
2011-05-25  7:59     ` Andreas Schwab
2011-05-25  8:10       ` Vikash Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3oc2sw4oh.fsf@redhat.com \
    --to=schwab@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=vikashjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox