From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6365 invoked by alias); 10 Aug 2011 14:47:13 -0000 Received: (qmail 6355 invoked by uid 22791); 10 Aug 2011 14:47:12 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Aug 2011 14:46:53 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7AEkpwG016362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 10 Aug 2011 10:46:51 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7AEkoMF012661; Wed, 10 Aug 2011 10:46:51 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7AEknKB010398; Wed, 10 Aug 2011 10:46:49 -0400 From: Tom Tromey To: Marc Khouzam Cc: "'gdb-patches\@sourceware.org'" Subject: Re: [patch] Tweak output of -var-info-path-expression References: Date: Wed, 10 Aug 2011 14:47:00 -0000 In-Reply-To: (Marc Khouzam's message of "Fri, 5 Aug 2011 09:54:46 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00221.txt.bz2 >>>>> "Marc" == Marc Khouzam writes: Marc> I'd like to re-submit a workaround I posted about a year ago, Marc> but never followed through with. Marc> So, here is the patch with a test. The test fails with Marc> the current HEAD (gets the syntax error) and succeeds with Marc> the patch applied. I've also had to update other tests Marc> to match the change. I think it is reasonable, just a few nits in the patch. Marc> Index: gdb/testsuite/gdb.mi/gdb11912.cc Jan has asked that new tests be given descriptive names instead of PR numbers. Marc> +if $verbose>1 then { Marc> + send_user "var-info-path-expression returned $cmd_output\n" Marc> + send_user "Using $path for data-evaluate-expression\n" Marc> +} Just use the verbose command with the level as an argument, like: verbose "var-info-path-expression returned $cmd_output" 2 (Note no \n as well.) Marc> + When we are in the scope of the base class or of one Marc> + of its children, the type field name will be interpreted Marc> + as a constructor, if it exists. Therefore, we must Marc> + indicate that the name is a class name by using the Marc> + 'class' keyword. */ I'd like this comment to have a reference to the PR, either the URL or "PR mi/11912". Tom