From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27714 invoked by alias); 16 Jan 2012 20:27:28 -0000 Received: (qmail 27706 invoked by uid 22791); 16 Jan 2012 20:27:26 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 20:27:11 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0GJSll8028357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jan 2012 14:28:58 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0GHk7jn006765; Mon, 16 Jan 2012 12:46:07 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0GHk5Eo025609; Mon, 16 Jan 2012 12:46:05 -0500 From: Tom Tromey To: Jan Kratochvil Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [RFC 1/8] Language independent bits References: <20120115203420.GA18901@host2.jankratochvil.net> Date: Mon, 16 Jan 2012 20:40:00 -0000 In-Reply-To: <20120115203420.GA18901@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 15 Jan 2012 21:34:20 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00576.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: >> + int expout_size; Jan> Memory object size does not fit into `int', it should be `size_t'. I agree, but I think that mixing different kinds of refactorings into one patch can be unnecessarily complicated and confusing. The 'int' is already there today. Tom