From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32394 invoked by alias); 4 Jun 2012 04:32:17 -0000 Received: (qmail 32384 invoked by uid 22791); 4 Jun 2012 04:32:16 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_YY,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 04:31:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q544VweM029790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Jun 2012 00:31:58 -0400 Received: from psique ([10.3.113.17]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q544VtNE030748; Mon, 4 Jun 2012 00:31:56 -0400 From: Sergio Durigan Junior To: Doug Evans Cc: GDB Patches , Tom Tromey Subject: Re: [PATCH 03/10] C language References: <1338665528-5932-1-git-send-email-sergiodj@redhat.com> <1338665528-5932-4-git-send-email-sergiodj@redhat.com> X-URL: http://www.redhat.com Date: Mon, 04 Jun 2012 04:32:00 -0000 In-Reply-To: (Doug Evans's message of "Sun, 3 Jun 2012 21:25:34 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00072.txt.bz2 On Monday, June 04 2012, Doug Evans wrote: > On Sat, Jun 2, 2012 at 12:32 PM, Sergio Durigan Junior > wrote: >> @@ -2651,11 +2665,16 @@ yylex (void) >> =C2=A0} >> >> =C2=A0int >> -c_parse (void) >> +c_parse (struct parser_state *par_state) >> =C2=A0{ >> =C2=A0 int result; >> - =C2=A0struct cleanup *back_to =3D make_cleanup (free_current_contents, >> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &expr= ession_macro_scope); >> + =C2=A0struct cleanup *back_to; >> + >> + =C2=A0/* Setting up the parser state. =C2=A0*/ >> + =C2=A0gdb_assert (par_state !=3D NULL); >> + =C2=A0pstate =3D par_state; >> + >> + =C2=A0back_to =3D make_cleanup (free_current_contents, &expression_mac= ro_scope); >> >> =C2=A0 /* Set up the scope for macro expansion. =C2=A0*/ >> =C2=A0 expression_macro_scope =3D NULL; > > IWBN to reset pstate back to NULL when done. I did that in a first draft, but then removed it. I will fix it for every patch, then (but won't resubmit all of them because that would be worthless). Thanks. --=20 Sergio