Re: [PATCH v3 03/19] Implement completion-limiting for complete_on_cmdlist.

Doug Evans
2015-08-23T01:05:12Z

Keith Seitz <keiths@redhat.com> writes:
> Differences in this revision:
>
> 1. Remove partial copy code from complete_on_cmdlist.
>
> ---
>
> This is the first of a series of smaller patches to switch over
> all completion functions to using add_completion to add
> completions to the completion list to be presented to the user.
>
> Note that in order to verify that this patch works as intended,
> one must override the backup completion counting in complete_line.
> [This backup code will be permanently removed in a later patch.]
> During testing, I have verified all patches with this planned code
> removal to verify that it works.
>
> First up is complete_on_cmdlist. Completion-limiting is already tested
> in gdb.base/completion.exp, so there are no new tests.
>
> gdb/ChangeLog
>
> * cli/cli-decode.c (complete_on_cmdlist): Use add_completion
> to determine whether to continue looking for completions.

LGTM