Re: [PATCH v3 00/19] New completer API

Doug Evans
2015-08-22T22:25:25Z

Keith Seitz <keiths@redhat.com> writes:
> On 08/07/2015 11:44 PM, Andrew Burgess wrote:
>>> I don't like boolean return values in this case. Forget knowing what
>>> happens under the covers (or now that you've read the proposed API).
>>> Just by reading "bool add_completion (struct completer_data *, const
>>> char *);" can you tell what the boolean return value means?
>>
>> No. But you could rename to
>> add_completion_then_should_more_completions_be_added (he jokes)
>> (though maybe add_completion_and_continue would work?). But
>> I would have just assumed a good comment was enough.
>
> I'll have to try and sneak something like that past Doug on some other
> series. :-)

Heh. :-)

fyi, reviewing this patchset is one of my projects for this weekend.