Re: [PATCH v3 04/19] Implement completion limiting for add_filename_to_list.

Doug Evans
2015-08-23T01:07:22Z

Keith Seitz <keiths@redhat.com> writes:
> Differences in this revision:
>
> 1. Remove partial copy code from add_filename_to_list.
>
> ---
>
> This patch converts add_filename_to_list to implement completion limiting.
> This function is used by both make_source_files_completion_list
> and maybe_add_partial_symbol. Tests have been added for both code
> pathways.
>
> gdb/ChangeLog
>
> * symtab.c (add_filename_to_list): Add completer_data argument and
> update all callers.
> Use add_completion.
>
> gdb/testsuite/ChangeLog
>
> * gdb.base/filesym.c (filesym2): Add external declaration.
> * gdb.base/filesym.exp: Compile newly added files.
> Add tests for completion limiting.
> * gdb.base/filesym2.c, gdb.base/filesym3.c, gdb.base/filesym4.c,
> gdb.base/filesym5.c: New files.

LGTM