From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119780 invoked by alias); 24 Jan 2017 19:21:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119713 invoked by uid 89); 24 Jan 2017 19:21:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 19:21:27 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v0OJDXZZ125741 for ; Tue, 24 Jan 2017 14:21:26 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 28667mv80v-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 24 Jan 2017 14:21:25 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jan 2017 19:21:24 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 24 Jan 2017 19:21:22 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 48FCE17D8056; Tue, 24 Jan 2017 19:24:19 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v0OJLM6c10617302; Tue, 24 Jan 2017 19:21:22 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 77E9111C04A; Tue, 24 Jan 2017 18:19:14 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52E0F11C04C; Tue, 24 Jan 2017 18:19:14 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.222]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 24 Jan 2017 18:19:14 +0000 (GMT) From: Andreas Arnez To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Use dwarf assembler in gdb.dwarf2/implptr-64bit.exp References: <1485250945-17594-1-git-send-email-yao.qi@linaro.org> <1485250945-17594-3-git-send-email-yao.qi@linaro.org> Date: Tue, 24 Jan 2017 19:21:00 -0000 In-Reply-To: <1485250945-17594-3-git-send-email-yao.qi@linaro.org> (Yao Qi's message of "Tue, 24 Jan 2017 09:42:25 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17012419-0016-0000-0000-00000430ECAB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17012419-0017-0000-0000-00002634F172 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-24_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701240121 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00505.txt.bz2 On Tue, Jan 24 2017, Yao Qi wrote: > diff --git a/gdb/testsuite/gdb.dwarf2/implptr-64bit.exp b/gdb/testsuite/gdb.dwarf2/implptr-64bit.exp > index b4dcbde..9565579 100644 > --- a/gdb/testsuite/gdb.dwarf2/implptr-64bit.exp > +++ b/gdb/testsuite/gdb.dwarf2/implptr-64bit.exp Looks generally OK to me, except... > + variable_label: variable { ...this causes FAILs on one of my systems unless replacing the "variable" above by "DW_TAG_variable". Note that "variable" is a Tcl command. > + { name v } > + { location { > + DW_OP_implicit_value 0x1 0x1 0x1 0x1 > + } SPECIAL_expr} > + { type :$struct_label "DW_FORM_ref$ref_addr_size" } > + } > + > + if { !$two_cu } { > + subprogram { > + { name main } > + { low_pc main addr } > + { high_pc "main+0x100" addr } > + { type %$int_label } > + { external 1 flag } > + } { > + variable { Same here. > diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp > index 1883c86..db51f5d 100644 > --- a/gdb/testsuite/lib/dwarf.exp > +++ b/gdb/testsuite/lib/dwarf.exp Looks OK to me as well, except a nit: > + switch -regexp -- $value { > + {^0x[[:xdigit:]]{1}$} {_op .byte $value} > + {^0x[[:xdigit:]]{2}$} {_op .byte $value} I'd rather replace the above two lines by a single one, to emphasize that both cases are handled in the same way: {^0x[[:xdigit:]]{1,2}$} {_op .byte $value} -- Andreas