From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15402-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32318 invoked by alias); 13 May 2002 08:48:42 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32289 invoked from network); 13 May 2002 08:48:38 -0000
Received: from unknown (HELO dell-paw-2.cambridge.redhat.com) (195.224.55.226)
  by sources.redhat.com with SMTP; 13 May 2002 08:48:38 -0000
Received: from north-pole.nickc.cambridge.redhat.com (host217-35-6-237.in-addr.btopenworld.com [217.35.6.237])
	by dell-paw-2.cambridge.redhat.com (Postfix) with ESMTP
	id 7FAEF2B560; Mon, 13 May 2002 09:48:37 +0100 (BST)
Received: from north-pole.nickc.cambridge.redhat.com.nickc.cambridge.redhat.com (localhost [127.0.0.1])
	by north-pole.nickc.cambridge.redhat.com (Postfix) with ESMTP
	id 6FD1B1C395; Mon, 13 May 2002 09:48:27 +0100 (BST)
To: thorpej@wasabisystems.com
Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Include sh64 support for shle-*-netbsdelf*
References: <20020511115603.W3435@dr-evil.shagadelic.org>
From: Nick Clifton <nickc@cambridge.redhat.com>
Date: Mon, 13 May 2002 01:48:00 -0000
In-Reply-To: <20020511115603.W3435@dr-evil.shagadelic.org>
Message-ID: <m3n0v4o2lh.fsf@north-pole.nickc.cambridge.redhat.com>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-05/txt/msg00450.txt.bz2

Hi Jason,

> sh64 support is already present for sh-*-netbsdelf*, but shle-*-netbsdelf*
> was apparently missed when this was added.
> 
> This patch is necessary in order to build GDB for shle-*-netbsdelf*, now
> that sh64 support has been added to GDB.
> 
> OK to commit?
> 
> bfd:
> 	* config.bfd (shle-*-netbsdelf*): Add target which includes
> 	sh64 support.

See below,

> opcodes:
> 	* configure.in (shle-*-*elf*): Include sh64 support.
> 	* configure: Regenerate.

Approved - please apply.


> Index: bfd/config.bfd
> ===================================================================
> RCS file: /cvs/src/src/bfd/config.bfd,v
> retrieving revision 1.89
> diff -u -r1.89 config.bfd
> --- bfd/config.bfd	11 May 2002 09:10:14 -0000	1.89
> +++ bfd/config.bfd	11 May 2002 18:42:46 -0000
> @@ -879,6 +879,13 @@
>      targ_defvec=bfd_elf32_shlin_vec
>      ;;
>  
> +  shle-*-netbsdelf*)
> +    targ_defvec=bfd_elf32_shlnbsd_vec
> +    targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec"
> +#ifdef BFD64
> +    targ_selvecs="${targ_selvecs} bfd_elf32_sh64_vec bfd_elf32_sh64l_vec bfd_elf64_sh64_vec bfd_elf64_sh64l_vec"
> +#endif
> +    ;;
>    sh*le-*-netbsdelf*)
>      targ_defvec=bfd_elf32_shlnbsd_vec
>      targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec"

Doesn't the "sh*le-*-netbsdelf*" target (immediately below the lines
you have added) already cover this situation ?

Cheers
        Nick