From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16963 invoked by alias); 15 Aug 2007 21:43:56 -0000 Received: (qmail 16896 invoked by uid 22791); 15 Aug 2007 21:43:55 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Aug 2007 21:43:53 +0000 Received: (qmail 7826 invoked from network); 15 Aug 2007 21:43:46 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Aug 2007 21:43:46 -0000 To: msnyder@sonic.net Cc: gdb-patches@sourceware.org, bug-readline@gnu.org Subject: Re: PATCH: readline/histexpand.c, resource leak References: <10015.12.7.175.2.1185934493.squirrel@webmail.sonic.net> <16798.12.7.175.2.1187138267.squirrel@webmail.sonic.net> From: Jim Blandy Date: Wed, 15 Aug 2007 21:43:00 -0000 In-Reply-To: <16798.12.7.175.2.1187138267.squirrel@webmail.sonic.net> (msnyder@sonic.net's message of "Tue, 14 Aug 2007 17:37:47 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00321.txt.bz2 msnyder@sonic.net writes: > Yeaaaahh... maybe the attached is better? Or is this use > of goto a little opaque? Personally, I'd add a new function 'free_history_words' and call it.