From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26882 invoked by alias); 24 Aug 2007 04:19:06 -0000 Received: (qmail 26766 invoked by uid 22791); 24 Aug 2007 04:19:05 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Aug 2007 04:18:59 +0000 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id l7O4ILUH016287; Fri, 24 Aug 2007 05:18:22 +0100 Received: from smtp.corp.google.com (spacemonkey3.corp.google.com [192.168.120.116]) by zps75.corp.google.com with ESMTP id l7O4II7M004829 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 23 Aug 2007 21:18:19 -0700 Received: from localhost.localdomain.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net [71.133.8.30]) (authenticated bits=0) by smtp.corp.google.com (8.13.8/8.13.8) with ESMTP id l7O4IFjh025119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 23 Aug 2007 21:18:16 -0700 To: Kai Tietz Cc: binutils@sourceware.org, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [PING x 2 patch]: libiberty pex for _WIN64 References: From: Ian Lance Taylor Date: Fri, 24 Aug 2007 04:19:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00459.txt.bz2 Kai Tietz writes: > > > 2007-08-03 Kai Tietz > > > > > > * pex-common.h: (pex_funcs): Retyped wait and exec_child to > pid_t. > > > * pex-djgpp.c: Likewise. > > > * pex-msdos.c: Likewise. > > > * pex-unix.c: Likewise. > > > * pex-win32.c: Likewise. > > > > This is OK if it passes bootstrap on a Unix or GNU/Linux system. > > It passes bootstrap on cygwin, x86_64 mingw, and i386 linux. > There was a bug that if configure detects the 'sys/types.h' defines the > pid_t, it was not included to define it. I added the include for it by > using the config.h define HAVE_SYS_TYPES_H. > > Is this patch OK to be applied ? Yes, this is OK. Thanks. Ian