From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51612-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13982 invoked by alias); 24 Oct 2007 17:12:44 -0000
Received: (qmail 13952 invoked by uid 22791); 24 Oct 2007 17:12:41 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Oct 2007 17:12:38 +0000
Received: (qmail 25950 invoked from network); 24 Oct 2007 17:12:36 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 24 Oct 2007 17:12:36 -0000
To: Carlos O'Donell <carlos@codesourcery.com>
Cc: gdb-patches@sourceware.org,  Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: [PATCH] Fix uninitialized use of variables.
References: <20071020172137.GC28823@lios> <m3prz5o1ub.fsf@codesourcery.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 24 Oct 2007 17:15:00 -0000
In-Reply-To: <m3prz5o1ub.fsf@codesourcery.com> (Jim Blandy's message of "Tue, 23 Oct 2007 16:20:12 -0700")
Message-ID: <m3myu8tp17.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00590.txt.bz2


Jim Blandy <jimb at codesourcery.com> writes:
> Carlos O'Donell <carlos at codesourcery.com> writes:
>> Index: gdb/remote.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/remote.c,v
>> retrieving revision 1.271
>> diff -u -p -r1.271 remote.c
>> --- gdb/remote.c	8 Oct 2007 12:55:09 -0000	1.271
>> +++ gdb/remote.c	18 Oct 2007 16:34:05 -0000
>> @@ -1343,7 +1343,8 @@ unpack_varlen_hex (char *buff,	/* packet
>>  static char *
>>  unpack_nibble (char *buf, int *val)
>>  {
>> -  ishex (*buf++, val);
>> +  if (!ishex (*buf++, val))
>> +    error (_("Unpacked nibble does not contain hex characters."));
>>    return buf;
>>  }
>
> This looks fine to me, although Daniel has thoughts on error handling
> in the remote protocol that I don't fully understand.
>
> But the error message is going to be obscure to users.  It should at
> least say something about the remote protocol packet being misformed.

You know, I can't see any harm in this change, whatever the remote.c
big picture is.  If you can make the error message something more
helpful, please commit.