From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8528 invoked by alias); 12 Feb 2009 17:35:43 -0000 Received: (qmail 8481 invoked by uid 22791); 12 Feb 2009 17:35:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_13,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Feb 2009 17:35:35 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n1CHZWWR007932 for ; Thu, 12 Feb 2009 12:35:32 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1CHZY4P009080 for ; Thu, 12 Feb 2009 12:35:34 -0500 Received: from opsy.redhat.com (vpn-13-214.rdu.redhat.com [10.11.13.214]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1CHZWnq017012; Thu, 12 Feb 2009 12:35:32 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 38F03508250; Thu, 12 Feb 2009 10:35:29 -0700 (MST) To: Vladimir Prus Cc: Marc Khouzam , gdb-patches@sources.redhat.com, Nick Roberts Subject: Re: MI solib notification References: <200901310010.46738.vladimir@codesourcery.com> <200902121212.53025.vladimir@codesourcery.com> <20090212132247.GA3107@caradoc.them.org> <200902121801.55254.vladimir@codesourcery.com> <20090212151337.GA9460@caradoc.them.org> From: Tom Tromey Reply-To: tromey@redhat.com Date: Thu, 12 Feb 2009 17:35:00 -0000 In-Reply-To: <20090212151337.GA9460@caradoc.them.org> (Daniel Jacobowitz's message of "Thu\, 12 Feb 2009 10\:13\:37 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00287.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: >> Yes, this runs everywhere except a.out and marks all breakpoints in solibs >> disabled, without printing any messages. *Then* we look over all solibs >> and call observer, but since all breakpoints are already disabled, >> breakpoint.c:disable_breakpoints_in_unloaded_shlib won't do anything, >> and won't say anything either. Daniel> I see. The comment in clear_solibs means that we will break SunOS Daniel> a.out shared libraries if we do this; they were previously not Daniel> disabled, since they won't ever be re-enabled. So I suggest not Daniel> making the observer call on a.out either. Otherwise OK. I actually already approved this hunk in another thread -- Paul Pluzhnikov's recent patch. My rationale for approving it was that for this observer to be reliable, it has to be called every place an so is freed. I was even thinking the call should probably be pushed into free_so. Now I'm thinking I don't understand this code as well as I thought I did :}. I hope I didn't cause too much trouble. Tom