From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11493 invoked by alias); 7 Jul 2009 18:23:31 -0000 Received: (qmail 11479 invoked by uid 22791); 7 Jul 2009 18:23:31 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jul 2009 18:23:25 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n67INK57019674; Tue, 7 Jul 2009 14:23:20 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n67INJk1015753; Tue, 7 Jul 2009 14:23:19 -0400 Received: from opsy.redhat.com (vpn-225-86.phx2.redhat.com [10.3.225.86]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n67INIOh023407; Tue, 7 Jul 2009 14:23:19 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id F25143784C7; Tue, 7 Jul 2009 12:23:17 -0600 (MDT) To: ppluzhnikov@google.com (Paul Pluzhnikov) Cc: gdb-patches@sourceware.org, archer@sourceware.org Subject: Re: [patch] fix for crash in python pretty-printer References: <20090707180121.D6ECE76BC0@localhost> From: Tom Tromey Reply-To: Tom Tromey Date: Tue, 07 Jul 2009 18:23:00 -0000 In-Reply-To: <20090707180121.D6ECE76BC0@localhost> (Paul Pluzhnikov's message of "Tue\, 7 Jul 2009 11\:01\:21 -0700 \(PDT\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00210.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Paul> Attached is a fix (applies both to mainline and archer-tromey-python). Paul> Tested on Linux/x86_64 with no regressions. This is ok. Thanks. Paul> P.S. Is there an "easy" way to find such mis-uses of TRY_CATCH? Paul> This one took me 2 hours to find :-( Not that I know of :( You could try coccinelle, I suppose. I've run it for other purposes on gdb, though with mixed results. Tom