From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25296 invoked by alias); 24 Jul 2009 22:07:42 -0000 Received: (qmail 25286 invoked by uid 22791); 24 Jul 2009 22:07:41 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_50,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Jul 2009 22:07:34 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6OM5VAH032724; Fri, 24 Jul 2009 18:05:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6OM5TA7003927; Fri, 24 Jul 2009 18:05:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6OM5Srd029363; Fri, 24 Jul 2009 18:05:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 5EE585081C2; Fri, 24 Jul 2009 16:05:28 -0600 (MDT) To: Pedro Alves Cc: gdb-patches@sourceware.org, "Ulrich Weigand" , Jan Kratochvil Subject: Re: [rfc] Infrastructure to disable breakpoints during inferior startup References: <200907231631.n6NGV2xR018887@d12av02.megacenter.de.ibm.com> <200907231751.01413.pedro@codesourcery.com> From: Tom Tromey Reply-To: Tom Tromey Date: Fri, 24 Jul 2009 22:49:00 -0000 In-Reply-To: <200907231751.01413.pedro@codesourcery.com> (Pedro Alves's message of "Thu\, 23 Jul 2009 17\:51\:00 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00610.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> BTW, I haven't had much of a chance to touch the multi-exec Pedro> patches since I posted them last. I was mostly waiting to see if Pedro> people had comments on the general design, and on the user Pedro> interface before proceeding further with it. If there's anything Pedro> I should do to make that (testing, review, comments) easier on Pedro> others, please let me know. I've been meaning to try this for a while. Today I finally got around to applying it. The patch didn't apply cleanly (nothing serious), and also had a couple problems compiling once I did apply it. I've appended my cleanup patch. One of the rs6000-tdep.c hunks is just a temporary workaround for unrelated build breakage. I put all this on a local git branch. I can push it to the archer repository if you, or anybody, wants to see it there. I still haven't actually tried it, but I hope to do so soon. Tom diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 51e8bbd..9cf5057 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -2490,7 +2490,7 @@ mips_software_single_step (struct frame_info *frame) CORE_ADDR pc, next_pc; pc = get_frame_pc (frame); - if (deal_with_atomic_sequence (gdbarch, pc)) + if (deal_with_atomic_sequence (gdbarch, aspace, pc)) return 1; next_pc = mips_next_pc (frame, pc); diff --git a/gdb/monitor.c b/gdb/monitor.c index 4cdfaae..4f258a9 100644 --- a/gdb/monitor.c +++ b/gdb/monitor.c @@ -705,6 +705,7 @@ monitor_open (char *args, struct monitor_ops *mon_ops, int from_tty) { char *name; char **p; + struct inferior *inf; if (mon_ops->magic != MONITOR_OPS_MAGIC) error (_("Magic number of monitor_ops struct wrong.")); diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index bc787f3..1d37eda 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -1075,7 +1075,7 @@ int ppc_deal_with_atomic_sequence (struct frame_info *frame) { struct gdbarch *gdbarch = get_frame_arch (frame); - struct gdbarch *aspace = get_frame_address_space (frame); + struct address_space *aspace = get_frame_address_space (frame); enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); CORE_ADDR pc = get_frame_pc (frame); CORE_ADDR breaks[2] = {-1, -1}; @@ -2950,8 +2950,8 @@ static struct variant variants[] = bfd_mach_rs6k, &tdesc_rs6000}, {"403", "IBM PowerPC 403", bfd_arch_powerpc, bfd_mach_ppc_403, &tdesc_powerpc_403}, - {"405", "IBM PowerPC 405", bfd_arch_powerpc, - bfd_mach_ppc_405, &tdesc_powerpc_405}, +/* {"405", "IBM PowerPC 405", bfd_arch_powerpc, */ +/* bfd_mach_ppc_405, &tdesc_powerpc_405}, */ {"601", "Motorola PowerPC 601", bfd_arch_powerpc, bfd_mach_ppc_601, &tdesc_powerpc_601}, {"602", "Motorola PowerPC 602", bfd_arch_powerpc, diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c index 4725757..0733824 100644 --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -1338,7 +1338,7 @@ spu_software_single_step (struct frame_info *frame) target = target & (SPU_LS_SIZE - 1); if (target != next_pc) - insert_single_step_breakpoint (gdbarch, target); + insert_single_step_breakpoint (gdbarch, aspace, target); } return 1;