2009-08-24 Tom Tromey * python/python-value.c (valpy_richcompare): Don't return from inside a TRY_CATCH. Index: python/python-value.c =================================================================== RCS file: /cvs/src/src/gdb/python/python-value.c,v retrieving revision 1.26 diff -u -r1.26 python-value.c --- python/python-value.c 14 Aug 2009 00:32:33 -0000 1.26 +++ python/python-value.c 24 Aug 2009 18:50:31 -0000 @@ -693,7 +693,10 @@ { value_other = convert_value_from_python (other); if (value_other == NULL) - return NULL; + { + result = -1; + break; + } switch (op) { case Py_LT: @@ -720,11 +723,16 @@ /* Can't happen. */ PyErr_SetString (PyExc_NotImplementedError, "Invalid operation on gdb.Value."); - return NULL; + result = -1; + break; } } GDB_PY_HANDLE_EXCEPTION (except); + /* In this case, the Python exception has already been set. */ + if (result < 0) + return NULL; + if (result == 1) Py_RETURN_TRUE;