From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68463-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2337 invoked by alias); 16 Nov 2009 18:26:45 -0000
Received: (qmail 2327 invoked by uid 22791); 16 Nov 2009 18:26:44 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Nov 2009 18:25:41 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAGIPPRP011075 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Mon, 16 Nov 2009 13:25:25 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAGIPOH5007288; 	Mon, 16 Nov 2009 13:25:24 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nAGIPNjr019280; 	Mon, 16 Nov 2009 13:25:23 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id EDD3137830D; Mon, 16 Nov 2009 11:25:22 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> 	<m23a4g5fur.fsf@whitebox.home> 	<8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com>
Reply-To: tromey@redhat.com
Date: Mon, 16 Nov 2009 18:26:00 -0000
In-Reply-To: <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> 	(Paul Pluzhnikov's message of "Sun, 15 Nov 2009 09:16:06 -0800")
Message-ID: <m3my2mtjhp.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00370.txt.bz2

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> But perhaps splitting on comma (after skipping any quoted expression
Paul> -- Foo::bar could have multiple parameters) is "good enough"? That
Paul> would allow 'disas &main + 1, &main + 5' to work.

I'm ok with changing this, mostly because I think the current approach
is bogus -- but I can understand that some people might not like it
because it is not backward compatible.

Are you planning to work on this?  If not, I think your original patch
is ok.

Tom