Re: [RFA] Handle older iconv programs

Doug Evans
2009-12-11T21:06:51Z

On Fri, Dec 11, 2009 at 1:03 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Mon, Dec 7, 2009 at 12:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>>
>> Doug> +  set_in_environ (iconv_env, "LANGUAGE", "en");
>>
>> I think "C" would be preferable here.
>> Or, just remove LANGUAGE from the environment.
>
> I am seeing a crash which I think directly relates to this patch:
>
> (top) r
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/usr/grte/v1/lib64/libthread_db.so.1".
>
> Program received signal SIGSEGV, Segmentation fault.
> *__GI_getenv (name=0x7ffff6cb8f85 "NGUAGE") at ../sysdeps/generic/getenv.c:93
> 93                if (name_start == ep_start && !strncmp (*ep + 2, name, len)

For reference sake, have you applied the accompanying patch to libiberty?

2009-12-07 Doug Evans <dje@google.com>

* pex-unix.c (pex_unix_exec_child): Save/restore environ.