From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22767 invoked by alias); 22 Dec 2009 18:23:10 -0000 Received: (qmail 22756 invoked by uid 22791); 22 Dec 2009 18:23:09 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Dec 2009 18:23:05 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIN3VV029775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Dec 2009 13:23:03 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIN2Dt004070; Tue, 22 Dec 2009 13:23:02 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIN1KD023683; Tue, 22 Dec 2009 13:23:02 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 4F4BF3781B0; Tue, 22 Dec 2009 11:23:01 -0700 (MST) From: Tom Tromey To: Hui Zhu Cc: gdb-patches ml , Michael Snyder , shuchang zhou , paawan oza Subject: Re: [RFC] Add support of software single step to process record References: Reply-To: tromey@redhat.com Date: Tue, 22 Dec 2009 18:23:00 -0000 In-Reply-To: (Hui Zhu's message of "Fri, 18 Dec 2009 16:21:10 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00345.txt.bz2 >>>>> ">" == Hui Zhu writes: >> This patch to make prec support software single step. >> I just try it with i386. Shuchang, please help me try it on mips. :) >> +int >> +inserted_single_step_breakpoint_p (void) >> +{ >> + if (single_step_breakpoints[0] != NULL >> + || single_step_breakpoints[1] != NULL) >> + return 1; >> + >> + return 1; >> +} This always returns 1. That seems suspicious to me. Tom